Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2 #451

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Numpy 2 #451

merged 8 commits into from
Jul 23, 2024

Conversation

vincefn
Copy link
Contributor

@vincefn vincefn commented Jul 14, 2024

See #450

All pycuda tests are passing (with python 12 and numpy 2.0, and cuda 11.8) , except TestDriver.test_register_host_memory which fails with ValueError: Cannot set the NumPy array 'base' dependency more than once

@vincefn
Copy link
Contributor Author

vincefn commented Jul 15, 2024

I added a new commit as I found an issue when accessing a sub-array using a[0,Ø], which overflowed because one of the shape dimensions was an np.int32 and with numpy 2 int+np.int32 returns a np.int32, which can easily overflow...

@inducer
Copy link
Owner

inducer commented Jul 15, 2024

Thanks! Here's a corresponding PR on Gitlab (with CI): https://gitlab.tiker.net/inducer/pycuda/-/merge_requests/92

@vincefn
Copy link
Contributor Author

vincefn commented Jul 16, 2024

Ok, looking at the CI results

If I read correctly the K40 raw log , there is the failure of TestDriver.test_register_host_memory (expected, see above, not sure if that can be corrected), and the TestGPUArray.test_curand_wrappers_8gb failure with an ECC error which leads to the following device context errors.

The Titan V and X have failures on tests involving texture - cuda 12 issue ?

@inducer
Copy link
Owner

inducer commented Jul 23, 2024

Finally had a chance to look this over, the changes look good to me. I've skip/xfailed (as appropriate) the failing tests. The ECC failure may well be hardware problem on our end.

@inducer
Copy link
Owner

inducer commented Jul 23, 2024

(Just waiting to see if anything else pops up on the Gitlab CI.)

@inducer
Copy link
Owner

inducer commented Jul 23, 2024

This looks good to go. Thanks for working on it. I'll roll a release with these changes.

@inducer inducer merged commit 00dd51a into inducer:main Jul 23, 2024
1 check passed
@inducer
Copy link
Owner

inducer commented Jul 23, 2024

https://pypi.org/project/pycuda/2024.1.1/

@vincefn
Copy link
Contributor Author

vincefn commented Jul 24, 2024

Thanks for the quick release !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants