Support calling functions with named args #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvcnt
commented
Dec 4, 2024
|
|
||
| // Handle named arguments. | ||
| let py_kwargs = PyDict::new(py); | ||
| for name in args.names_map()?.iter() { |
There was a problem hiding this comment.
I was unable to use map here due to my lack of knowledge with Rust.
pvcnt
commented
Dec 4, 2024
src/lib.rs
Outdated
| .collect::<PyResult<Vec<PyObject>>>()?; | ||
|
|
||
| // Handle named arguments. | ||
| let py_kwargs = PyDict::new(py); |
There was a problem hiding this comment.
I could not understand why new_bound does not work.
There was a problem hiding this comment.
new_bound is for a newer version of pyo3 than this package was on. It's there now.
pvcnt
commented
Dec 4, 2024
inducer
force-pushed
the
support-named-args
branch
from
ac358b6 to
0f93f42
Compare
inducer
force-pushed
the
support-named-args
branch
from
0f93f42 to
93e4a19
Compare
|
Awesome, thank you for your help @inducer! May I ask for a new release, if that is possible? 😇 |
|
Sure thing. https://github.com/inducer/starlark-pyo3/releases/tag/v2024.1.5 Here's the build that should eventually upload the release to the package index: https://github.com/inducer/starlark-pyo3/actions/runs/12167634055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal PR to fix #22. I'm not familiar at all with Rust, my coding style may hence not be optimal.