Add functionality to find derivative recurrences from PDE (via Taylor) #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hirish99
commented
Jun 3, 2024
•
hirish99
commented
- Revised version of I want to check what goes into a pull request for sumpy #197, with better branch name (see review comments there)
|
inducer
changed the title
inducer
reviewed
Jun 24, 2024
| assert val == 0 | ||
|
|
||
|
|
||
| def test_recurrence_finder_laplace_three_d(): |
There was a problem hiding this comment.
Look into @pytest.mark.parametrize, generalize test_recurrence_finder_laplace to do this, too.
There was a problem hiding this comment.
I am not sure if it is worth parametrizing these tests since every pde recurrence test requires a different coefficient producing function to check our answers.
sumpy/recurrence.py
Outdated
| """ | ||
|
|
||
|
|
||
| def get_pde_in_recurrence_form(laplace): |
There was a problem hiding this comment.
Maybe think about what additional unit tests might make sense (for the constituent functions).
| @@ -0,0 +1,348 @@ | |||
| """ | |||
| .. autofunction:: get_pde_in_recurrence_form | |||
There was a problem hiding this comment.
Maybe add some narrative here on how this works.
inducer
changed the title
|
Closing, superseded by #204. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.