Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dockerfile.example #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrelino
Copy link

This fixes #5 in upstream: Docker example image for frontend won't build

This fixes industrial-edge#5 in upstream: Docker example image for frontend won't build
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

@adrelino
Copy link
Author

it is only 1 character change, please review and merge so I can start my next pull request

@ingoaf
Copy link
Contributor

ingoaf commented Oct 2, 2023

@adrelino Today, I brought the topic of not reviewing the PRs up in our internal Siemens forum. I will come back to you as soon as there are any updates. Thanks for your contribution so far! :)

@ingoaf
Copy link
Contributor

ingoaf commented Oct 9, 2023

@adrelino following up as promised: I talked to @Milan-Hurban and he told me that

@Milan-Hurban if I understood you correctly could you please close both open PRs?

In any case, like I said before: thank you very much for your contribution and I hope we can move forward with the development soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker example image for frontend won't build
4 participants