Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured what is wrong with ours currently has more to do with whatever arbitrary setuptools version I was using being an old version that can not interpret anything in the
[metadata]
section ofsetup.cfg
(this was added in setuptools version 30.3.0 and re pypa/setuptools#862). That being said after doing some reading on community standards regarding version parsing on [PEP 39] (https://www.python.org/dev/peps/pep-0396/) and looking at some other open source projects I follow, I went with peeling the version number off the fileflow package's__version__
attribute insetup.py
directly. This was also semi informed by a small poll of 3 situations whereby we determined setuptools might be version 3.3, 12.1, 18.2, or 32.3.1 depending when you last installed virtualenv/pip/setuptools itself.For example this was the problem for me locally, against setuptools version 18.2. I am explicitly installing the commit before this PR:
vs after this PR; commit 10be84 is the latest in this branch:
We could require our build process to use a minimum setuptools version so that we are >30.3.0 and leave it the old way, but this was more in line with what I saw elsewhere and works back through many setuptools versions.
I also left this at the same point release since I was just fixing the metadata, which I felt doesn't warrant a new release number.