Skip to content
This repository has been archived by the owner on Jun 12, 2020. It is now read-only.

move python to 3.8, upgrade psycopg to 2.84 #49

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

eric38383
Copy link

@eric38383 eric38383 commented May 29, 2020

TECH-7630

Non-technical Context

None

Technical Context

Upgrade Docker Image to Python 3.8

  • The upgrade required psycopg 2.84

I received an error building 3.8

Screen Shot 2020-05-29 at 12 45 34 PM

After doing some research, it seems that this was fixed

psycopg/psycopg2#854

Reproduction Steps

Manual Testing Instructions

  • Pull down the branch and
  • run docker-compose build docker-compose up
  • Exec into the container and check the python version. It should be 3.8.3

QA Checklist

Developer

  • Ensure code complies with the style guide
  • Devise edge cases to test the bug fix or feature being merged
  • Make sure the code is clean and understandable
  • Ensure code is not overly inefficient
  • [N/A] Ensure documentation is understandable and accurate, including:
    • Code comments and doc strings
    • Technical documentation

Reviewer

  • Ensure code complies with the style guide
    • If there are few or minor issues, add inline GitHub comments
    • If there are many issues or it seems like the developer did not follow the style guide, leave a comment asking them to do so
  • Devise edge cases to test the bug fix or feature being merged
  • Make sure the code is clean and understandable
    • [na] Ask for inline comments on unclear sections
  • Ensure code is not overly inefficient
  • [na] Ensure documentation is understandable and accurate, including:
    • [na] Code comments and doc strings
    • [na] Technical documentation

@eric38383
Copy link
Author

eric38383 commented May 29, 2020

@greglinch Not sure if the version change affects anything in production. We can discuss this before merging in

@greglinch
Copy link
Contributor

@eric38383 Looks good to me locally, thanks! Production doesn't use a docker container yet and I only re-install requirements there when needed. Given that there's nothing on the horizon that will need a new installation, it shouldn't affect anything there for now.

@eric38383 eric38383 merged commit d0853f0 into develop Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants