Encoding/decoding negative integers and bigger integers #90
Conversation
lib/asn1/decoders/der.js
Outdated
| @@ -244,6 +244,10 @@ DERNode.prototype._decodeInt = function decodeInt(buffer, values) { | |||
| var raw = buffer.raw(); | |||
| var res = new bignum(raw); | |||
|
|
|||
| if ((raw[0] & 0x80) > 0) { // negative | |||
There was a problem hiding this comment.
Should it be !== 0? Please consider putting the comment on the line before if.
There was a problem hiding this comment.
Another note: should we rather use bignum.fromTwos here, and avoid creating new bignum if the result is negative?
There was a problem hiding this comment.
As far as I can tell, bignum.fromTwos doesn't exist.
lib/asn1/encoders/der.js
Outdated
| // check if sign bit is occupied | ||
| if ((bitLength % 8) == 0) { | ||
| // when number is of form 10..0 no correction is needed | ||
| if (num.zeroBits() + 1 != num.bitLength()) { |
lib/asn1/encoders/der.js
Outdated
| // check if sign bit is occupied | ||
| if ((bitLength % 8) == 0) { | ||
| // when number is of form 10..0 no correction is needed | ||
| if (num.zeroBits() + 1 != num.bitLength()) { |
lib/asn1/encoders/der.js
Outdated
| var bitLength = num.bitLength(); | ||
| var width = Math.ceil(bitLength / 8) * 8; | ||
| // check if sign bit is occupied | ||
| if ((bitLength % 8) == 0) { |
lib/asn1/encoders/der.js
Outdated
| } | ||
| } | ||
| numArray = num.toTwos(width).toArray(); | ||
| //console.log(numArray); |
There was a problem hiding this comment.
Please remove all commented code.
|
I actually just added eslint to the |
|
Thx, I also want to fix encoding JS integers > 2^32-1 while we are here. If you don't mind I'll redirect them to BN. |
|
Hi, I fixed lint issues and also added support for integers >= 2^31. I don't see BN.fromTwos in BN library so I don't see an opportunity to handle it in a more efficient way. Note that test "should encode OCSP request" fails, but it fails without my changes too. |
killerstorm
changed the title
|
Is this going to be merged? |
|
Is this only a conflict issue ? I need number support > 32 bits. |
I added support for encoding & decoding negative integers. Existing implementation was producing erroneous values.
I've added tests for numbers at the edges: -1, -128, -129. No extensive testing was done.