Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver-major release: 5.0.0 #219

Closed
wants to merge 1 commit into from

Conversation

fanatid
Copy link
Collaborator

@fanatid fanatid commented Jul 4, 2019

First, @indutny @calvinmetcalf thanks for trust and allowance to maintain this project. And sorry for delay.

Initially, I planned fill CHANGELOG.md and submit PR with minor version, but almost immediately I remembered that master branch already have semver-major changes which was never published. So I decide:

  1. Summarize all current changes, submit PR with CHANGELOG for semver-major version: 5.0.0
  2. Merge/update/close current not semver-major PR's and release semver-minor version: 5.1.0 and so on..
  3. Start work on unfinished semver-major changes from Breaking changes for the next major release #129 for version: 6.0.0

I'm not sure that I'll able finish 6.0.0, but I'll try do this.

5.0.0 can be considered as intermediate version. It's fastest way receive bn.js with patches from ~2 last years.

--

@indutny @calvinmetcalf I'd prefer not release version 5.0.0 without ACK. Are you ok with this plan?
No need merge this PR, this mostly preview. If you agree with proposed process, I'll commit changes directly to master.

--

@axic
Copy link
Contributor

axic commented Jul 4, 2019

Can some other renames make it into the release to make the API more consistent?

@fanatid
Copy link
Collaborator Author

fanatid commented Jul 4, 2019

Do you mean andln => andrn? I think yes, this should be simple change.

@indutny
Copy link
Owner

indutny commented Jul 4, 2019

👍

@fanatid
Copy link
Collaborator Author

fanatid commented Jul 7, 2019

Published v5.0.0 (8a8d9ba)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants