Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport(4.x): Fix serious issue in .toString(16) (#295) #309

Merged
merged 1 commit into from
Nov 11, 2024
Merged

backport(4.x): Fix serious issue in .toString(16) (#295) #309

merged 1 commit into from
Nov 11, 2024
+15 −5

Commits on Nov 11, 2024

  1. Fix serious issue in .toString(16) (indutny#295) 

    * Add test for `.toString(16)`

* Fix serious issue in `.toString(16)`

The hex encoding of some numbers is wrong. Since the string representation
is also used for interoperability between BigInt libraries, this bug is
causing a number modification when a BN.js number is converted into
another BigInt class, for example the BigNumber of ethers.js.
    @alexdupre @ChALkeR
    alexdupre authored and ChALkeR committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    de9c33a View commit details
    Browse the repository at this point in the history