add script to compute precomputed curves, elliptic.usePrecomputed, tests #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal is to be able to sacrifice bundle size for performance by choosing to use a precomputed curve at runtime:
also, the validation in the PresetCurve is expensive and unnecessary to do at runtime for pre-defined curves (i think but correct me if i'm wrong!)
this PR incorporates #188 , but i can adjust and rebase if that's merged first
this is kind of a big PR, but we noticed (at Exodus) that
elliptic.ec('p256')
takes ~1s in React Native on an iPhone Xs, and in that environment the tradeoff of a slightly bigger bundle as a result of bundling a precomputed curve is more than offset by the savings in computation time (~700ms savings)relevant PR in Exodus: ExodusMovement#1
thanks @fanatid for help in figuring out how to do this