-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bn.js to address Buffer deprecation #197
Conversation
EDIT: |
|
@fanatid |
Oh, sorry. |
Ok, I will add package-lock.json back. |
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indicates asn1.js 4.10.1
still uses bn.js 4.11.8
, which cause another Buffer deprecation.
So I opened a PR indutny/asn1.js#116 to update bn.js
in asn1.js
too.
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is opened.
browserify/browserify-rsa#12
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
"dependencies": { | ||
"bn.js": { | ||
"version": "4.11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello core developers, how should I proceed this and related PRs? |
@fanatid |
Closing as a duplicate, since a maintainer opened a same PR in #210 |
Closes #196