Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bn.js to address Buffer deprecation #197

Closed
wants to merge 3 commits into from
Closed

Update bn.js to address Buffer deprecation #197

wants to merge 3 commits into from

Conversation

exoego
Copy link

@exoego exoego commented Sep 11, 2019

Closes #196

@exoego
Copy link
Author

exoego commented Sep 11, 2019

Hmm, some tests failed due to this changes in bn.js.
How should these tests be addressed?
Does this indicated an issue in elliptic, or in bn.js ?

EDIT:
I fixed the tests in elliptic 83ff218.

@fanatid
Copy link
Contributor

fanatid commented Sep 12, 2019

package-lock.json should not be added. There still no decision how this should be handled. See #191

@exoego
Copy link
Author

exoego commented Sep 12, 2019

@fanatid
It seems that Travis complains unless package-lock.json included

@fanatid
Copy link
Contributor

fanatid commented Sep 12, 2019

Oh, sorry. package-lock.json in this repo now, that's why Travis show error. On each dependency update package-lock.json should be updated too...

@exoego
Copy link
Author

exoego commented Sep 12, 2019

Ok, I will add package-lock.json back.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indicates asn1.js 4.10.1 still uses bn.js 4.11.8, which cause another Buffer deprecation.
So I opened a PR indutny/asn1.js#116 to update bn.js in asn1.js too.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"dependencies": {
"bn.js": {
"version": "4.11.8",
Copy link
Author

@exoego exoego Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

coveralls commented Sep 16, 2019

Coverage Status

Coverage decreased (-0.006%) to 89.114% when pulling 1894eb9 on exoego:buffer-deprecation into 71e4e8e on indutny:master.

@exoego
Copy link
Author

exoego commented Sep 29, 2019

Hello core developers, how should I proceed this and related PRs?

@exoego
Copy link
Author

exoego commented Jan 20, 2020

@fanatid
Updated bn.js to 5.1.1 since newer version have been released while waiting review.

@exoego
Copy link
Author

exoego commented Jan 20, 2020

Closing as a duplicate, since a maintainer opened a same PR in #210

@exoego exoego closed this Jan 20, 2020
@exoego exoego deleted the buffer-deprecation branch January 20, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning on Buffer
3 participants