Allow pass pers to drbg from ec.sign #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanatid just curious, what kind of data do you pass there? Does it follow any spec? |
|
I want pass |
|
Ok then... May I ask you to write a test for it? Maybe cross-check the output value with secp256k1 with it's pers data. |
|
Oh, also... please let me know when you will make changes. Github does not send notifications on new commits in PR. |
|
@indutny updated! |
|
Landed and released, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #68 I forgot mentioned that secp256k1-node v3.0.0 also need pass extra data to drbg.