Esm #133
Open
Esm #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2023 14:00
w3nl
reviewed
Feb 19, 2024
There was a problem hiding this comment.
I would recommended to add also "type": "module"
w3nl
reviewed
Feb 19, 2024
| const net = require('net'); | ||
| const os = require('os'); | ||
| const ip = require('..'); | ||
| import assert from 'assert'; |
There was a problem hiding this comment.
For internal Node packages, i should prefer to add node: before the package, like
import assert from 'node:assert';
Makes it more clear that it is just a native Node package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuffertoUint8Array( for friendlier browser bundles )