Fix logic of ip.address('public/private') #61
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverses the check in the filter method, as the definition of .filter() says return true for elements that should be in the filtered array aka pass the test. Previously it was doing exactly the opposite.
|
The tests are failing for some other reason. |
|
This regressed with f52f79e @bryanwayb |
|
Any update on this? |
|
Hi @indutny any update on this? |
|
This issue is a security vulnerability imo -- the user may accidentally start listen on a public address rather than a private. As there are no recent commits.. Is this repository maintained? |
Maybe we need a CVE like CVE-2023-42282 to attract the author. |
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverses the check in the filter method of
ip.address(), as the definitionof
Array.prototype.filter()says"returns array of elements that pass the test".It is currently doing exactly the opposite.
We noticed this, as we were doing
ip.address('public')but received a private address.https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter