Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eslint, support node>=6.0.0, update document, fix minor bugs #94

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

HMarzban
Copy link

@HMarzban HMarzban commented Oct 25, 2018

I have a long interface list of my devices, and npm ip package gives me the wrong IP always,
So I dig deep into files project and find out that we can retrieve interface IP address by the name of interfaces, but not mention in the document, so update document and inline document of ip.address(name, family) function in lib.js.

I start using npm run test and npm fix but unfortunately face to lots of error, so I replace jscs and jshint with eslint and config base on standard javascript styles.

meantime, when I use Eslint, appear Nodejs warning and deprecate function that's used in ip package, therefore I replaced them with the new one which aims to Nodejs 6 and above.

#93, #86, #81, #80, #73, #67, #65, #59, #56, #21 fixed

@HMarzban HMarzban changed the title add eslint, support node>=4.0.0, update document, fix minor bugs add eslint, support node>=6.0.0, update document, fix minor bugs Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant