Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update xml2js version #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update xml2js version #32

wants to merge 1 commit into from

Conversation

littleskunk
Copy link
Contributor

@indutny
Copy link
Owner

indutny commented May 17, 2017

Thank you for this! Do tests pass after update?

@littleskunk
Copy link
Contributor Author

I was not able to execute the tests with and without my change.

@indutny
Copy link
Owner

indutny commented May 17, 2017

For me 3 of 4 tests pass without this change, and with change only 1 of 4 does pass. As far as I know there were some API changes in xml2js which are incompatible with current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littleskunk @indutny