Fix loading of resources using incorrect offset #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the HashMap of resources is being initialized, the start location of every file was being set as the start location of the first file, since the offset wasn't being updated after adding each file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this awesome project.
When using
__loader__.get_resource_loader(package).open_resource(filename), we were getting a strange result: the contents of the file came out together with the content of other embedded files.Turns out it was always reading from the start of the first file, since the data offset wasn't getting updated as it moved along the files.
This is my first contribution to a Rust project, so feel free to tell me if I made some mistake, though the change is simple enough that I hope I haven't 😄