Stop bundling setuptools for Python 3.12+ #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems technically sound. But I'd like a few questions answered at #300 (comment) before merging this. |
indygreg
approved these changes
Aug 31, 2024
For parity with the `ensurepip` and `venv` modules, which no longer install setuptools as of Python 3.12: - python/cpython#95299 - python/cpython@ece20db Fixes indygreg#300.
edmorley
force-pushed
the
python-312-no-setuptools
branch
from
61726b5
to
def7bc2
Compare
|
I've rebased on |
|
Are you happy for this to be merged? :-) |
|
Thanks for rebasing! I might ship this after the other changes? |
zanieb
approved these changes
Sep 9, 2024
|
Eh, after thinking a bit more I don't really want to ship |
|
Many thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parity with the
ensurepipandvenvmodules, which no longer install setuptools as of Python 3.12:Fixes #300.