fix divide by zero

inexio · Sep 27, 2021 · 19d5602 · 19d5602
1 parent 2762851
commit 19d5602
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/config/codecommunicator/ios.go b/config/codecommunicator/ios.go
@@ -158,7 +158,12 @@ func (c *iosCommunicator) getMemoryComponentMemoryUsage(ctx context.Context, poo
 		}
 
 		// usage = ( used / (free+used) ) * 100
-		usage, _ := used.DivRound(used.Add(free), 4).Mul(decimal.NewFromInt(100)).Float64()
+		total := used.Add(free)
+		if total.IsZero() {
+			return nil, errors.New("total memory is zero, division by zero not possible")
+		}
+
+		usage, _ := used.DivRound(total, 4).Mul(decimal.NewFromInt(100)).Float64()
 
 		pools = append(pools, device.MemoryPool{
 			Label: &poolLabel,

diff --git a/internal/deviceclass/property/operator.go b/internal/deviceclass/property/operator.go
@@ -519,6 +519,10 @@ func (m *divideNumberModifier) modify(ctx context.Context, v value.Value) (value
 		return nil, err
 	}
 
+	if b.IsZero() {
+		return nil, errors.New("divisor is zero, division by zero not possible")
+	}
+
 	result := a.DivRound(b, m.precision)
 	return value.New(result), nil
 }