renaming & logging

core/network/snmp_client.go

@@ -273,6 +273,9 @@ func (s *SNMPClient) SNMPWalk(ctx context.Context, oid string) ([]SNMPResponse,
 	var err error
 	if s.client.Version != gosnmp.Version1 {
 		response, err = s.client.BulkWalkAll(oid)
+		if err != nil {
+			log.Ctx(ctx).Trace().Err(err).Msg("bulk walk failed")
+		}
 	}
 	if s.client.Version == gosnmp.Version1 || err != nil {
 		response, err = s.client.WalkAll(oid)

core/request/check_interface_metrics_request_process.go

@@ -115,16 +115,16 @@ out:
 		}
 	}
 
-	readInterfacesResponse.Interfaces = removeInterface(readInterfacesResponse.Interfaces, filterIndices, 0)
+	readInterfacesResponse.Interfaces = filterInterfaces(readInterfacesResponse.Interfaces, filterIndices, 0)
 
 	return readInterfacesResponse, nil
 }
 
-func removeInterface(interfaces []device.Interface, toRemove []int, alreadyRemoved int) []device.Interface {
+func filterInterfaces(interfaces []device.Interface, toRemove []int, alreadyRemoved int) []device.Interface {
 	if len(toRemove) == 0 {
 		return interfaces
 	}
-	return append(interfaces[:toRemove[0]-alreadyRemoved], removeInterface(interfaces[toRemove[0]+1-alreadyRemoved:], toRemove[1:], toRemove[0]+1)...)
+	return append(interfaces[:toRemove[0]-alreadyRemoved], filterInterfaces(interfaces[toRemove[0]+1-alreadyRemoved:], toRemove[1:], toRemove[0]+1)...)
 }
 
 func addCheckInterfacePerformanceData(interfaces []device.Interface, r *monitoringplugin.Response) error {

core/request/request_test.go

@@ -62,7 +62,7 @@ func TestRemoveInterfaces(t *testing.T) {
 				toRemove = append(toRemove, j)
 			}
 		}
-		interfaces = removeInterface(interfaces, toRemove, 0)
+		interfaces = filterInterfaces(interfaces, toRemove, 0)
 		assert.Equal(t, i/2, len(interfaces), "expected removed length and actual length differs")
 	}
 }