Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic support for VMware ESXi, HP ProCurve and Clavister Firewalls #31

Merged
merged 12 commits into from
Apr 26, 2021

Conversation

studost
Copy link
Contributor

@studost studost commented Apr 9, 2021

No description provided.

@toberd
Copy link
Contributor

toberd commented Apr 9, 2021

Hey,
thanks for your contribution. Could you please attach some snmprec files of your device types? Then we can simulate and test your changes. Unfortunately, we don't have access to any of these device types.

@studost
Copy link
Contributor Author

studost commented Apr 11, 2021

Hey,
thanks for your contribution. Could you please attach some snmprec files of your device types? Then we can simulate and test your changes. Unfortunately, we don't have access to any of these device types.

Is there a way to anonymous snmprec files because the systems i use are in production?

@TheFireMike
Copy link
Contributor

We've got the same problem with our own devices and an easy solution to this is yet to be found. ;-)

If you want you can delete all the OIDs which are not present in the device class. We also don't really need any information about the interfaces.
You can also send us these files privat to our mail team@thola.io if you wish.

@studost
Copy link
Contributor Author

studost commented Apr 25, 2021

Send snmprec files via mail.

Copy link
Contributor

@TheFireMike TheFireMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! We need a few changes but then we can merge this PR.

config/device-classes/generic/clavister.yaml Outdated Show resolved Hide resolved
config/device-classes/generic/procurve.yaml Outdated Show resolved Hide resolved
config/device-classes/generic/procurve.yaml Outdated Show resolved Hide resolved
config/mappings/sysObjectID.yaml Outdated Show resolved Hide resolved
studost and others added 5 commits April 26, 2021 13:07
Co-authored-by: Mika Meyer <51948405+TheFireMike@users.noreply.github.com>
Co-authored-by: Mika Meyer <51948405+TheFireMike@users.noreply.github.com>
Co-authored-by: Mika Meyer <51948405+TheFireMike@users.noreply.github.com>
Co-authored-by: Mika Meyer <51948405+TheFireMike@users.noreply.github.com>
Co-authored-by: Mika Meyer <51948405+TheFireMike@users.noreply.github.com>
@studost studost requested a review from TheFireMike April 26, 2021 11:12
Copy link
Contributor

@TheFireMike TheFireMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for your contribution!

@TheFireMike TheFireMike merged commit eb2a310 into inexio:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants