Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FI-3380 - Duplicate id fix #11

Merged
merged 2 commits into from
Nov 5, 2024
Merged

FI-3380 - Duplicate id fix #11

merged 2 commits into from
Nov 5, 2024

Conversation

karlnaden
Copy link
Contributor

Summary

forward chain test internal ids were not unique due to the lack of the inclusion of the profile in the id. The profile was added to the id

Testing Guidance

There are no visible changes to the tests

  • run rspec
  • run against the reference server using the UI and ensure it runs to completion (will take a while) without any purple errors and that forward chaining tests are included (e.g., Organization and Network tests, "Server capable of forward chaining with partof.name")

Jammjammjamm
Jammjammjamm approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the ticket number to the PR title

@karlnaden karlnaden changed the title Duplicate id fix FI-3380 - Duplicate id fix Nov 5, 2024
@karlnaden karlnaden merged commit 0526b6d into main Nov 5, 2024
2 checks passed
@karlnaden karlnaden deleted the duplicate-id-fix branch November 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jammjammjamm Jammjammjamm Jammjammjamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlnaden @Jammjammjamm