update spec

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
inferno-framework · Jan 21, 2025 · f01941c · f01941c
1 parent c0b2c58
commit f01941c
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 13 deletions.
diff --git a/spec/inferno/dsl/fhir_resource_validation_spec.rb b/spec/inferno/dsl/fhir_resource_validation_spec.rb
@@ -153,11 +153,22 @@
           .to_return(status: 200, body: invalid_outcome)
       end
 
-      it 'includes resourceType/id in error message' do
-        result = validator.resource_is_valid?(resource2, profile_url, runnable)
+      context 'when log_messages is set to true' do
+        it 'includes resourceType/id in error message' do
+          result = validator.resource_is_valid?(resource2, profile_url, runnable)
 
-        expect(result).to be(false)
-        expect(runnable.messages.first[:message]).to start_with("#{resource2.resourceType}/#{resource2.id}:")
+          expect(result).to be(false)
+          expect(runnable.messages.first[:message]).to start_with("#{resource2.resourceType}/#{resource2.id}:")
+        end
+      end
+
+      context 'when log_messages is set to false' do
+        it 'does not log messages' do
+          result = validator.resource_is_valid?(resource2, profile_url, runnable, log_messages: false)
+
+          expect(result).to be(false)
+          expect(runnable.messages).to be_empty
+        end
       end
     end
 

diff --git a/spec/inferno/dsl/fhir_validation_spec.rb b/spec/inferno/dsl/fhir_validation_spec.rb
@@ -114,19 +114,31 @@
           .to_return(status: 200, body: invalid_outcome)
       end
 
-      it 'includes resourceType/id in error message' do
-        result = validator.resource_is_valid?(resource, profile_url, runnable)
+      context 'when log_messages is set to true' do
+        it 'includes resourceType/id in error message' do
+          result = validator.resource_is_valid?(resource, profile_url, runnable)
 
-        expect(result).to be(false)
-        expect(runnable.messages.first[:message]).to start_with("#{resource.resourceType}/#{resource.id}:")
+          expect(result).to be(false)
+          expect(runnable.messages.first[:message]).to start_with("#{resource.resourceType}/#{resource.id}:")
+        end
+
+        it 'includes resourceType in error message if resource.id is nil' do
+          resource.id = nil
+          result = validator.resource_is_valid?(resource, profile_url, runnable)
+
+          expect(result).to be(false)
+          expect(runnable.messages.first[:message]).to start_with("#{resource.resourceType}:")
+        end
       end
 
-      it 'includes resourceType in error message if resource.id is nil' do
-        resource.id = nil
-        result = validator.resource_is_valid?(resource, profile_url, runnable)
+      context 'when log_messages is set to false' do
+        it 'does not log messages' do
+          resource.id = nil
+          result = validator.resource_is_valid?(resource, profile_url, runnable, log_messages: false)
 
-        expect(result).to be(false)
-        expect(runnable.messages.first[:message]).to start_with("#{resource.resourceType}:")
+          expect(result).to be(false)
+          expect(runnable.messages).to be_empty
+        end
       end
     end