FI-2271: Update OAuth input requirements #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 214 214
Lines 10708 10708
Branches 991 991
=======================================
Hits 8246 8246
Misses 1884 1884
Partials 578 578
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Jammjammjamm
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug: optional OAuth inputs (e.g. in the Demo Suite) were being treated as required. This should be fixed.
Testing Guidance
Bug repro: Go to Group 1 in the Demo Suite and Run. Run isn't submittable until a value has been entered for the OAuth input.
After the fix, this should be submittable without having to make any changes. Also check suites with required OAuth inputs and confirm those function as normal, especially with JSON and YAML inputs.