-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2318 Allow for form data at session create endpoint #429
Merged
Merged
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1c4ae0b
Allow for form data at session create endpoint
360dgries 19cf92e
FI-2395: Data rights legend (#424)
bmath10 4b9122c
Change unless to if
360dgries 0190dbf
Update docs site to point to preview of new docs site. (#430)
arscan d0d56cd
FI-2426: Fix tagged request query (#432)
Jammjammjamm bd57638
Release 0.4.27 (#433)
Jammjammjamm b7ecc81
FI-2266: Add inferno new CLI generator (#408)
Shaumik-Ashraf 0eaadd4
Check for JSON instead of not form-data
360dgries 6135e59
lowercase json
360dgries 3215452
Change to safe method call
360dgries 144929d
FI-2222: no tests hang fix (#425)
Shaumik-Ashraf 01cd1fe
Allow for form data at session create endpoint
360dgries 651606b
Change unless to if
360dgries 9028f82
Check for JSON instead of not form-data
360dgries 3a83289
lowercase json
360dgries 7cd3fc6
Change to safe method call
360dgries 8a55eeb
Merge branch 'FI-2318-Session-form-POST' of https://github.com/infern…
360dgries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
present?
instead of!blank?
.Why check that the content type isn't form data instead of checking whether the content type is json? Also, that isn't the only content type used by forms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I've changed it to just check for json instead before attempting to parse as a json. I'm still learning in's and out's of request handling -- is there any form data that is non json that could need additional handling? My understanding is that Hanabi will handle most forms automatically.