Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2433: Collapse request details #448

Merged
merged 9 commits into from
Feb 23, 2024
Merged

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Allows full JSON responses (and request bodies) to collapse and be copied into the clipboard.

Screenshot 2024-02-08 at 11 33 07 AM Screenshot 2024-02-08 at 11 33 14 AM

Testing Guidance

Try it, make sure it works, let me know if anything is weird.

@AlyssaWang AlyssaWang requested a review from arscan February 8, 2024 16:36
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 77.68%. Comparing base (022aeaf) to head (42ce615).

Files Patch % Lines
client/src/components/_common/CopyButton.tsx 75.47% 7 Missing and 6 partials ⚠️
client/src/components/_common/CollapseButton.tsx 86.84% 0 Missing and 5 partials ⚠️
...nt/src/components/RequestDetailModal/CodeBlock.tsx 93.93% 0 Missing and 2 partials ⚠️
...mponents/RequestDetailModal/RequestDetailModal.tsx 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   77.54%   77.68%   +0.14%     
==========================================
  Files         228      230       +2     
  Lines       11443    11510      +67     
  Branches     1076     1083       +7     
==========================================
+ Hits         8873     8942      +69     
+ Misses       1944     1936       -8     
- Partials      626      632       +6     
Flag Coverage Δ
backend 93.89% <ø> (ø)
frontend 70.92% <85.41%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlyssaWang AlyssaWang changed the title FI-2433-collapse-request FI-2433: Collapse request details Feb 16, 2024
@tstrass tstrass self-requested a review February 16, 2024 19:05
@AlyssaWang AlyssaWang requested a review from tstrass February 23, 2024 20:08
@AlyssaWang AlyssaWang merged commit 21b7aef into main Feb 23, 2024
10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2433-collapse-request branch February 23, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants