Update new website link on old documentation site #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google still returns the old documentation site which links to the new site at `/index_new.html` that's now a 404. I replaced the link with `https://inferno-framework.github.io` and changed the wording from "before we release it on February 13th." Intuitively it feels nicer if it links to `/documentation` instead of `/`, but I kept it this way since its probably better for SEO. I also didn't nit pick the wording or styling around it and maybe we could use a stronger depreciation notice or even a JavaScript redirect but I just wanted to get rid of the 404. Feel free to close this if something like that is in the works (or I can start a new PR for that if we need it).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage 77.79% 77.79%
=======================================
Files 233 233
Lines 11583 11583
Branches 1099 1099
=======================================
Hits 9011 9011
Misses 1940 1940
Partials 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arscan
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Google still returns the old documentation site which links to the new site at
/index_new.htmlthat's now a 404. I replaced the link withhttps://inferno-framework.github.ioand changed the wording from "before we release it on February 13th."Intuitively it feels nicer if it links to
/documentationinstead of/, but I kept it this way since its probably better for SEO.I also didn't nit pick the wording or styling around it and maybe we could use a stronger depreciation notice or even a JavaScript redirect but I just wanted to get rid of the 404. Feel free to close this if something like that is in the works (or I can start a new PR for that if we need it).
Testing Guidance
Double check my markdown please. I'll use the link inevitably if this gets deployed.