Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fi 2576 inferno new gemspec patch #465

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

Shaumik-Ashraf
Copy link
Contributor

@Shaumik-Ashraf Shaumik-Ashraf commented Mar 13, 2024

Summary

It turns out RubyGems wasn't shipping the inferno new templates, so inferno new my_test_kit wouldn't work on fresh installs.

You can download the gem from https://rubygems.org/downloads/inferno_core-0.4.30.gem, rename it to a .tgz file, extract the contents, and then extract data.tar.gz to verify this.

Testing Guidance

I ran npm run build && gem build inferno_core.gemspec successfully, and then extracted the gem file to make sure lib/inferno/apps/cli/templates was there. However I'm not sure how to fully test this besides waiting for the next release of inferno_core.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (38ce2a7) to head (e911ddb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files         233      233           
  Lines       11591    11591           
  Branches     1087     1087           
=======================================
  Hits         9006     9006           
  Misses       1965     1965           
  Partials      620      620           
Flag Coverage Δ
backend 93.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shaumik-Ashraf Shaumik-Ashraf merged commit 7550079 into main Mar 13, 2024
10 checks passed
@Shaumik-Ashraf Shaumik-Ashraf deleted the fi-2576-inferno-new-gemspec-patch branch March 13, 2024 12:58
@rpassas rpassas mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants