FI-2533: Add general test endpoints #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 80.11% 80.41% +0.29%
==========================================
Files 236 238 +2
Lines 11744 11862 +118
Branches 1136 1150 +14
==========================================
+ Hits 9409 9539 +130
+ Misses 1676 1664 -12
Partials 659 659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jammjammjamm
commented
Mar 21, 2024
| # response.body = { abc: 123 }.to_json | ||
| # response.format = :json | ||
| # end | ||
| def make_response |
There was a problem hiding this comment.
I wanted this to be build_response, but that is an existing method in Hanami::Action. Very open to better name suggestions.
arscan
reviewed
Apr 10, 2024
arscan
reviewed
Apr 10, 2024
arscan
approved these changes
Apr 10, 2024
Jammjammjamm
force-pushed
the
fi-2533-add-general-test-routes
branch
from
d243d70 to
5368353
Compare
Jammjammjamm
force-pushed
the
fi-2533-add-general-test-routes
branch
from
5368353 to
a71aa5c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds a
SuiteEndpointclass for creating generic endpoints for client testing.ResumeTestRoutehas also been refactored to be a subclass ofSuiteEndpoint.As part of this change, it was necessary to update a bunch of the
dry-*gems, so this branch also includes various small changes to handle api changes in those gems.Testing Guidance
ResumeTestRoutehas been refactored to be based on SuiteEndpoint, and is covered by unit tests. The wait group in the demo suite can also be used to see that those endpoints are working as intended.A group has been added to the end of the demo suite with a simple SuiteEndpoint. Make a POST to the endpoint with Postman/curl/etc. using a bearer token you provide, and you should see that the test resumes, the request can be identified by name or tags, and the response has all of the headers you see in the tool you used to make the request.