FI-2791: Revert resume test route refactor #497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When there are multiple consecutive wait tests, there is a race condition which can put Inferno into a state where it fails to resume the test run. This branch reverts
resume_test_route
to no longer be based on suite endpoints which should prevent Inferno from getting into that bad state.Testing Guidance
Locally in the PAS test kit, run
bundle update inferno_core
, which should bump core to0.4.37
. In the client suite, run theDemonstrate Workflow Support
group, which should end up in a bad state:This change was released as
0.4.37.dev
so that we could use it in the connectathon. If you set core's version to0.4.37.dev
in the PAS test kit, or run the same tests on QA, they should no longer hang at this point.