Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2791: Revert resume test route refactor #497

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

When there are multiple consecutive wait tests, there is a race condition which can put Inferno into a state where it fails to resume the test run. This branch reverts resume_test_route to no longer be based on suite endpoints which should prevent Inferno from getting into that bad state.

Testing Guidance

Locally in the PAS test kit, run bundle update inferno_core, which should bump core to 0.4.37. In the client suite, run the Demonstrate Workflow Support group, which should end up in a bad state:

Screenshot 2024-05-30 at 9 39 09 AM

This change was released as 0.4.37.dev so that we could use it in the connectathon. If you set core's version to 0.4.37.dev in the PAS test kit, or run the same tests on QA, they should no longer hang at this point.

@Jammjammjamm Jammjammjamm requested a review from tstrass May 30, 2024 13:47
@Jammjammjamm Jammjammjamm self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (c3eb7c2) to head (8e89feb).

Files Patch % Lines
lib/inferno/dsl/suite_endpoint.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   80.11%   79.71%   -0.41%     
==========================================
  Files         240      240              
  Lines       11909    11924      +15     
  Branches     1166     1167       +1     
==========================================
- Hits         9541     9505      -36     
- Misses       1705     1756      +51     
  Partials      663      663              
Flag Coverage Δ
backend 92.27% <97.05%> (-1.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm force-pushed the fi-2791-revert-resume-refactor branch from 909c00a to 8e89feb Compare June 5, 2024 12:21
@Jammjammjamm Jammjammjamm merged commit 4550618 into main Jun 5, 2024
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2791-revert-resume-refactor branch June 5, 2024 12:25
@rpassas rpassas mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants