Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2745: Skip loading validator sessions when using inferno console #499

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

Creating validator sessions was breaking inferno console when the validator service wasn't running. This branch prevents inferno from initializing validator sessions when using the console.

Testing Guidance

With no services running:
On main:

  • Add the g10 tests following the instructions in the Gemfile
  • Run bundle exec inferno c and it should fail
    On this branch:
  • Add the g10 tests following the instructions in the Gemfile
  • Run bundle exec inferno c and it shouldn't fail

@Jammjammjamm Jammjammjamm requested review from dehall and rpassas May 31, 2024 17:56
@Jammjammjamm Jammjammjamm self-assigned this May 31, 2024
Copy link
Contributor

@rpassas rpassas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer get errors:

__connect_nonblock': Connection refused - connect(2) for 127.0.0.1:6379 (redis://localhost:6379) (RedisClient::CannotConnectError)
__connect_nonblock': Connection refused - connect(2) for 127.0.0.1:6379 (Errno::ECONNREFUSED)

@Jammjammjamm Jammjammjamm force-pushed the fi-2745-allow-skipping-session-creation branch from 7dff491 to 2e4d84c Compare June 5, 2024 12:26
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (4550618) to head (2e4d84c).

Files Patch % Lines
lib/inferno/config/boot/validator.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   79.71%   79.70%   -0.01%     
==========================================
  Files         240      240              
  Lines       11924    11925       +1     
  Branches     1167     1168       +1     
==========================================
  Hits         9505     9505              
- Misses       1756     1757       +1     
  Partials      663      663              
Flag Coverage Δ
backend 92.25% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm merged commit 5c31622 into main Jun 5, 2024
9 of 10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2745-allow-skipping-session-creation branch June 5, 2024 12:30
@rpassas rpassas mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants