Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2887 Remove banner info from readme because that belongs in the docs site. #527

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

arscan
Copy link
Contributor

@arscan arscan commented Sep 16, 2024

I do not see a reason to have just this type of documentation in the inferno core readme. The appropriate place is the documentation site.

We've added that in inferno-framework/inferno-framework.github.io#52

FYI @mrnosal

@arscan arscan requested a review from Jammjammjamm September 16, 2024 14:49
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (48532ce) to head (498025d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files         253      253           
  Lines       13351    13351           
  Branches     1290     1290           
=======================================
  Hits        10663    10663           
  Misses       1939     1939           
  Partials      749      749           
Flag Coverage Δ
backend 91.84% <ø> (ø)
frontend 74.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arscan arscan merged commit d4a676c into main Sep 17, 2024
10 checks passed
@arscan arscan deleted the FI-2887-banner-docs branch September 17, 2024 19:25
@rpassas rpassas mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants