Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3172: Fix validator sessions #531

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

This branch fixes the bug where validator session ids would get set to sessionId rather than a unique identifier.

Testing Guidance

Load up g10/us core and run multiple sessions with different us core versions at the same time. On main, this should cause the validator session error. That error should no longer be present on this branch.

@Jammjammjamm Jammjammjamm self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (8bce37b) to head (34e192d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files         253      253           
  Lines       13351    13352    +1     
  Branches     1289     1290    +1     
=======================================
+ Hits        10663    10664    +1     
  Misses       1939     1939           
  Partials      749      749           
Flag Coverage Δ
backend 91.84% <100.00%> (+<0.01%) ⬆️
frontend 74.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm requested a review from arscan September 27, 2024 15:00
@Jammjammjamm Jammjammjamm merged commit 2c537e4 into main Sep 27, 2024
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-3172-fix-validator-sessions branch September 27, 2024 15:32
@rpassas rpassas mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants