Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3275 debug: inferno execute input validation #542

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Shaumik-Ashraf
Copy link
Contributor

Summary

Found a bug on inferno execute where it was requiring inputs that should not be required. The diff will explain a lot.

Testing Guidance

  1. Checkout this branch
  2. Make a new branch: git checkout -b bug-execute-input-validation-test
  3. Merge PR FI-3182 Inferno execute unified short ids option #540: git merge origin/fi-3182-clean-diff
  4. Run this, which fails on main and fi-3182-clean-diff, but should succeed now:
bundle exec inferno execute --suite infra_test -g 1 -t 4.01 --inputs suite_input:a outer_group_input:b inner_group_input:c test_input:d

Have to do it this way because #540 includes another bug fix, but I feel that this bug fix should get merged separately and sooner.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (a031394) to head (00b7772).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         260      260           
  Lines       11361    11361           
  Branches     1252     1252           
=======================================
  Hits         9544     9544           
  Misses       1807     1807           
  Partials       10       10           
Flag Coverage Δ
backend 92.11% <ø> (ø)
frontend 79.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shaumik-Ashraf Shaumik-Ashraf self-assigned this Oct 10, 2024
@Shaumik-Ashraf Shaumik-Ashraf changed the title debug debug: inferno execute input validation Oct 10, 2024
@Shaumik-Ashraf Shaumik-Ashraf changed the title debug: inferno execute input validation FI-3275 debug: inferno execute input validation Oct 10, 2024
@Shaumik-Ashraf Shaumik-Ashraf merged commit 708bb78 into main Oct 10, 2024
10 checks passed
@Shaumik-Ashraf Shaumik-Ashraf deleted the bug-execute-input-validation branch October 10, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants