-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3285: Add fields to backend services access mode #544
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
+ Coverage 84.05% 84.07% +0.02%
==========================================
Files 261 261
Lines 11396 11386 -10
Branches 1255 1251 -4
==========================================
- Hits 9579 9573 -6
+ Misses 1807 1803 -4
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -249,7 +249,10 @@ export const getAccessFields = ( | |||
title: 'Client ID', | |||
description: 'Client ID provided during registration of Inferno', | |||
optional: true, | |||
hide: !accessValues.get('refresh_token'), | |||
hide: | |||
authType === 'backend_services' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use this logic to just assign 'access_token'
or 'refresh_token'
to a variable that gets used here rather than repeating the logic for each field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep totally works -- updated.
@@ -234,6 +234,11 @@ export const getAccessFields = ( | |||
accessValues: Map<string, unknown>, | |||
components: TestInput[], | |||
): TestInput[] => { | |||
const backendServicesHideCondition = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't just for backend services, though, it's for everything, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of? I named it that since it stipulates backend_services
in the check itself but I think this could be better named regardless -- updated.
… FI-3285-backend-services-access
… FI-3285-backend-services-access
Summary
Updates fields for backend services access mode to display
client_id
,token_url
, andencryption_algorithm
.Testing Guidance
Check that the above fields appear if access token is populated.