Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3367 Patch execute rollup #550

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

Shaumik-Ashraf
Copy link
Contributor

Summary

I realized execute was not respecting result summarizer rollup behavior at all, and with this PR it will at least respect the old behavior. Customized rollup behavior is still not supported (because the children of custom rollup groups make their way into the results array). I'll patch that bug in a future PR and ticket.

This PR along with inferno-framework/tls-test-kit#20 and onc-health/onc-certification-g10-test-kit#577 is blocking inferno-framework/inferno-reference-server#182, which is succesfully running g10 in CI.

Testing Guidance

Just see the working CI run: https://github.com/inferno-framework/inferno-reference-server/actions/runs/11524446739/job/32084615655?pr=182

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (7f1431a) to head (b549caf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files         262      262           
  Lines       11409    11409           
  Branches     1254     1254           
=======================================
  Hits         9591     9591           
  Misses       1808     1808           
  Partials       10       10           
Flag Coverage Δ
backend 92.18% <ø> (ø)
frontend 79.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shaumik-Ashraf Shaumik-Ashraf merged commit 39042af into main Oct 28, 2024
10 checks passed
@Shaumik-Ashraf Shaumik-Ashraf deleted the fi-3367-patch-execute-rollup branch October 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants