-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3475: Unit testing improvements #559
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
- Coverage 84.05% 84.05% -0.01%
==========================================
Files 262 262
Lines 11409 11415 +6
Branches 1255 1256 +1
==========================================
+ Hits 9590 9595 +5
- Misses 1809 1810 +1
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. How much do existing spec tests need to change to work with this? Should existing tests override this added context, or will they need to be updated to align?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this inferno_core
and a test kit created by inferno new
and both worked.
It shouldn't interfere with existing specs, as demonstrated in this PR: inferno-framework/subscriptions-test-kit#13 |
4196492
to
8d83a85
Compare
This branch factors out common unit testing behaviors. For a demonstration of a test kit using this functionality, see inferno-framework/subscriptions-test-kit#13
The template has also been updated to use these shared behaviors. If you generate a new test kit, comment out the inferno_core requirement in the gemspec, and point at this inferno_core branch in the Gemfile, the unit tests should pass in the created test kit.