Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3023: Add default env vars and documentation to validator dockerfile #562

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Nov 21, 2024

Summary

In anticipation of inferno-resource-validator v1.0.59, this sets two new environment variable defaults in the docker image:

  • SESSION_CACHE_IMPLEMENTATION=PassiveExpiringSessionCache
    • Previously the PassiveExpiringSessionCache was the only implementation but then a different session cache was added, without support for a "never expire" value
  • SESSION_CACHE_DURATION=-1
    • Sets the session cache to "never expire". This is set on every test kit currently, but it makes more sense to keep these defaults here so we don't have to update dozens of test kits if things change behind the scenes like this.

And adds documentation explaining these variables plus the recommended update sequence when there's a new version.

Note I added the = to the other env var lines because I got warnings like this from the build otherwise:

 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 20)

Testing Guidance

To build the image for 1.0.59 and load it locally without pushing to docker hub, run:

docker buildx build --platform linux/arm64 --build-arg "PROJECT_VERSION=1.0.59" --tag "infernocommunity/inferno-resource-validator:1.0.59" --load .

(this is the same as the build script in the same folder, but with --load instead of --push and only building for arm64)

After that, this can be tested directly against g10 by running this branch: onc-healthit/onc-certification-g10-test-kit#592

@dehall dehall requested a review from Jammjammjamm November 21, 2024 19:26
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (88bc16c) to head (420661b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files         262      262           
  Lines       11415    11415           
  Branches     1256     1256           
=======================================
  Hits         9595     9595           
  Misses       1810     1810           
  Partials       10       10           
Flag Coverage Δ
backend 92.17% <ø> (ø)
frontend 79.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dehall
Copy link
Contributor Author

dehall commented Nov 22, 2024

Update: validator-wrapper 1.0.59 was just now released upstream so marking this as draft while I test that out

@dehall dehall marked this pull request as draft November 22, 2024 17:05
@dehall
Copy link
Contributor Author

dehall commented Nov 22, 2024

Looks like no additional changes needed for 1.0.59 so moving forward with that

@dehall dehall marked this pull request as ready for review November 22, 2024 18:16
validator/README.md Outdated Show resolved Hide resolved
Co-authored-by: Stephen MacVicar <Jammjammjamm@users.noreply.github.com>
@dehall dehall merged commit a46e47d into main Nov 22, 2024
10 checks passed
@dehall dehall deleted the fi-3023-bump-validator branch November 22, 2024 19:19
@Shaumik-Ashraf Shaumik-Ashraf mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants