Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3366: Fetch report date from test results #567

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Previous report dates were just the current date and time. Updated dates should reflect the last time update from test group results.

Testing Guidance

Run a test group and wait a few minutes -- when viewing the report, the date should not be the current time.

@AlyssaWang AlyssaWang requested review from arscan and mrnosal November 26, 2024 00:35
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (9196912) to head (edbff54).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nts/TestSuite/TestSuiteDetails/TestSuiteReport.tsx 45.45% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   84.05%   83.97%   -0.09%     
==========================================
  Files         262      262              
  Lines       11415    11430      +15     
  Branches     1256     1260       +4     
==========================================
+ Hits         9595     9598       +3     
- Misses       1810     1822      +12     
  Partials       10       10              
Flag Coverage Δ
backend 92.17% <ø> (ø)
frontend 79.19% <45.45%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you open it before running anything, you get something like this.

Screenshot 2024-11-25 7 58 58 PM

I'm not sure what should be there. I suppose in this case you could set it to the suite updated date. Or in this case just do the current time. Or hide it. It's not a meaningful thing, but in case someone happens to click on report like this it shouldn't look like a bug :)

I was thinking maybe you could make the report link not clickable if you haven't run anything, but sometimes its nice to be able to see what a page is about before having done anything.

@arscan
Copy link
Contributor

arscan commented Nov 26, 2024

Other than that one edge case (opening before any tests are run), it looks great. So go ahead and fix that and I'll approve.

@mrnosal
Copy link
Contributor

mrnosal commented Nov 26, 2024

I was thinking maybe you could make the report link not clickable if you haven't run anything, but sometimes its nice to be able to see what a page is about before having done anything.

If nothing has been run, and you can still click "Report" to see that page, then there should be no date shown, with a placeholder like 'n/a' or '--'

@AlyssaWang AlyssaWang requested a review from arscan November 26, 2024 17:56
@AlyssaWang
Copy link
Collaborator Author

Added a N/A case handler:

Screenshot 2024-11-26 at 12 57 03 PM

@AlyssaWang AlyssaWang merged commit 18bc135 into main Nov 26, 2024
6 checks passed
@AlyssaWang AlyssaWang deleted the FI-3366-report-date branch November 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants