-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3366: Fetch report date from test results #567
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 84.05% 83.97% -0.09%
==========================================
Files 262 262
Lines 11415 11430 +15
Branches 1256 1260 +4
==========================================
+ Hits 9595 9598 +3
- Misses 1810 1822 +12
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you open it before running anything, you get something like this.
I'm not sure what should be there. I suppose in this case you could set it to the suite updated date. Or in this case just do the current time. Or hide it. It's not a meaningful thing, but in case someone happens to click on report like this it shouldn't look like a bug :)
I was thinking maybe you could make the report link not clickable if you haven't run anything, but sometimes its nice to be able to see what a page is about before having done anything.
Other than that one edge case (opening before any tests are run), it looks great. So go ahead and fix that and I'll approve. |
If nothing has been run, and you can still click "Report" to see that page, then there should be no date shown, with a placeholder like 'n/a' or '--' |
Summary
Previous report dates were just the current date and time. Updated dates should reflect the last time update from test group results.
Testing Guidance
Run a test group and wait a few minutes -- when viewing the report, the date should not be the current time.