Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3511: Fix json handling #568

Merged
merged 3 commits into from
Dec 5, 2024
Merged

FI-3511: Fix json handling #568

merged 3 commits into from
Dec 5, 2024

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

This branch fixes an issue where suite endpoints recognize requests with a content type of application/json as json and automatically parse the bodies, but don't recognize application/fhir+json as json.

Testing Guidance

This will be difficult to manually test, but if you check out b900d28216862e32b2dd3e955dfb49ebeea342f6 you can verify that the unit test for application/fhir+json fails prior to the fix.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (15eb38c) to head (20a56a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   83.94%   84.37%   +0.43%     
==========================================
  Files         263      265       +2     
  Lines       11460    11475      +15     
  Branches     1261     1261              
==========================================
+ Hits         9620     9682      +62     
+ Misses       1830     1783      -47     
  Partials       10       10              
Flag Coverage Δ
backend 93.34% <100.00%> (+1.14%) ⬆️
frontend 79.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm force-pushed the fi-3511-fix-json-handling branch from e256b6c to 20a56a2 Compare December 5, 2024 17:28
@Jammjammjamm Jammjammjamm merged commit f7c5b45 into main Dec 5, 2024
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-3511-fix-json-handling branch December 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants