FI-3302: Add CI actions to template #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 275 275
Lines 11668 11668
Branches 1302 1302
=======================================
Hits 9836 9836
Misses 1822 1822
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vanessuniq
approved these changes
Dec 17, 2024
Jammjammjamm
force-pushed
the
fi-3302-add-ci-actions-to-template
branch
from
ef6d780 to
d5137c5
Compare
Shaumik-Ashraf
approved these changes
Dec 19, 2024
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
There was a problem hiding this comment.
Can we add workflow_dispatch:, it never hurts
Jammjammjamm
force-pushed
the
fi-3302-add-ci-actions-to-template
branch
from
d5137c5 to
10e381e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds testing and linting github actions to the template. The template didn't already include rubocop, so this adds rubocop as well.
Testing Guidance
bundle exec bin/inferno new my-test-kit. In the new test kit, you should see the actions in.github, and the new test kit should not contain any linting errors. The unit tests will not pass until we have a new release with #561.