Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fi 3597 fix js build #579

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Fi 3597 fix js build #579

merged 2 commits into from
Dec 19, 2024

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

This branch removes an outdated js file and updates the publish script to automatically remove old js files prior to performing a new js build.

Testing Guidance

  • Comment out the gem push line of publish.sh.
  • ./publish.sh

In SMART test kit:

  • mkdir inferno
  • copy inferno_core-0.5.3.gem from inferno core into the inferno directory
  • cd inferno
  • tar -xvf inferno_core-0.5.3.gem
  • tar -xvzf data.tar.gz
  • copy inferno_core.gemspec from inferno core into the inferno directory
  • cd ..
  • comment out the inferno core requirement in smart_app_launch_test_kit.gemspec
  • add gem 'inferno_core', path: './inferno' to the Gemfile
  • bundle
  • run the test kit
  • verify that the auth info choices are working as expected

@Jammjammjamm Jammjammjamm self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (89c7b38) to head (d8cb8a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files         274      274           
  Lines       11663    11663           
  Branches     1302     1302           
=======================================
  Hits         9831     9831           
  Misses       1822     1822           
  Partials       10       10           
Flag Coverage Δ
backend 92.61% <ø> (ø)
frontend 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vanessuniq vanessuniq merged commit af50a63 into main Dec 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants