FI-3643: Check input components for auth #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 84.29% 84.30%
=======================================
Files 275 275
Lines 11668 11686 +18
Branches 1302 1307 +5
=======================================
+ Hits 9836 9852 +16
- Misses 1822 1824 +2
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| const [authType, setAuthType] = React.useState<string>( | ||
| input.options?.components ? (input.options?.components[0].default as string) : 'public', | ||
| authComponent?.default ? (authComponent.default as string) : 'public', |
There was a problem hiding this comment.
I think this needs to check what the actual list options are and choose the first value in case public has been removed.
There was a problem hiding this comment.
Good catch -- updated
Jammjammjamm
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix for the following:
Current behavior: Auth inputs check first component provided for default selection settings. If another component is provided, inputs break.
Expected behavior: Inputs should find first component with type auth
See branch fi-3093-debug
Testing Guidance
Pull this branch into fi-3093-debug -- should be able to open inputs without errors. Check auth inputs, access inputs, and type selector; all should work.
Cases to check:
componentsis empty and/or undefined -- AuthInfo Suitecomponentshas onlyauth_type-- AuthInfo Suitecomponentshas only something else -- SMART STU1componentshas something else andauth_type-- add the following toInputAuth.tsxon line 22:input.options?.components?.push({ name: 'auth_type', default: 'symmetric', });Selector should show Confidential Symmetric.