Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3628: Add check for locked input in checkbox group #590

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

AlyssaWang
Copy link
Contributor

Summary

Fixes a bug where checkboxes in a group input were not locking when the entire group is locked. Locked groups now lock all individual inputs.

Testing Guidance

Test on Demo Group in Demo Suite; there are now separate tests for the following:

  • Checkbox Group Input Example (no locking)
  • Locked Checkbox Group Input Example (entire group locked)
  • Locked Single Checkbox in Group Input Example (one option locked)

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (7392983) to head (d5badab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   84.30%   84.31%           
=======================================
  Files         275      275           
  Lines       11688    11691    +3     
  Branches     1307     1307           
=======================================
+ Hits         9854     9857    +3     
  Misses       1824     1824           
  Partials       10       10           
Flag Coverage Δ
backend 92.63% <100.00%> (+<0.01%) ⬆️
frontend 79.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlyssaWang AlyssaWang merged commit 4620ff3 into main Jan 15, 2025
6 checks passed
@AlyssaWang AlyssaWang deleted the FI-3628-locked-checkbox-alterable branch January 15, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants