Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3598: Add title to auth inputs and consolidate input modes #591

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

AlyssaWang
Copy link
Contributor

Summary

Since this PR removes the cosmetic differences between InputAuth and InputAccess, those inputs types have been internally consolidated into one component that now takes a mode field to determine what to render.

Testing Guidance

AuthInfo Suite should run as expected, inputs should appear as expected. All inputs of type Auth or Access should be titled.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (4620ff3) to head (472943c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client/src/components/InputsModal/InputFields.tsx 57.14% 3 Missing ⚠️
...ient/src/components/InputsModal/Auth/InputAuth.tsx 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   84.31%   84.28%   -0.03%     
==========================================
  Files         275      274       -1     
  Lines       11691    11601      -90     
  Branches     1307     1291      -16     
==========================================
- Hits         9857     9778      -79     
+ Misses       1824     1815       -9     
+ Partials       10        8       -2     
Flag Coverage Δ
backend 92.63% <ø> (ø)
frontend 79.11% <92.59%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlyssaWang AlyssaWang merged commit 78f4f7e into main Jan 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants