Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin concurrent-ruby to 1.3.4 #596

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

Shaumik-Ashraf
Copy link
Contributor

@Shaumik-Ashraf Shaumik-Ashraf commented Jan 21, 2025

Summary

This PR fixes onc-healthit/onc-certification-g10-test-kit#610 and the broken inferno new command. The bugs are due to activesupport and concurrent-ruby gems. Activesupport PR rails/rails#54264 should also fix it but has not been released yet.

Testing Guidance

  1. Checkout this branch
  2. Generate a new test kit:
bundle exec inferno new fix-test
  1. Add this line to fix-test/Gemfile:
gem 'inferno_core', git: 'https://github.com/inferno-framework/inferno-core', branch: 'pin-concurrent-ruby-1.3.4'
  1. Make sure the new test kit works via Docker:
cd fix-test
./setup.sh
./run.sh
  1. Clean up
cd ..
rm -rf fix-test

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (8e17a4a) to head (62c14fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         274      274           
  Lines       11601    11601           
  Branches     1291     1291           
=======================================
  Hits         9778     9778           
  Misses       1815     1815           
  Partials        8        8           
Flag Coverage Δ
backend 92.63% <ø> (ø)
frontend 79.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shaumik-Ashraf Shaumik-Ashraf requested review from Jammjammjamm and vanessuniq and removed request for Jammjammjamm and vanessuniq January 21, 2025 17:26
@Shaumik-Ashraf Shaumik-Ashraf merged commit 3a23fe1 into main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants