Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3637: Add fetch bundle resources to core #599

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vanessuniq
Copy link
Contributor

Summary

This PR adds the fetch_all_bundled_resources method to the FHIR Client DSL, to retrieve FHIR resources from a given bundle. A shared example spec has also been added to ensure method integrity by verifying that fetch_all_bundled_resources is not overridden in subclasses. This helps maintain consistency and prevents unintended redefinition of the method in test kits.

Testing Guidance

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.30%. Comparing base (4331857) to head (c2f6bd2).

Files with missing lines Patch % Lines
lib/inferno/dsl/fhir_client.rb 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   84.28%   84.30%   +0.01%     
==========================================
  Files         274      274              
  Lines       11603    11627      +24     
  Branches     1295     1303       +8     
==========================================
+ Hits         9780     9802      +22     
- Misses       1815     1817       +2     
  Partials        8        8              
Flag Coverage Δ
backend 92.62% <91.66%> (-0.01%) ⬇️
frontend 79.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant