-
Notifications
You must be signed in to change notification settings - Fork 268
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### What problem does this PR solve? 1. Fix: memory leak when parsing sparse vector. 2. Fix: parser reduce warning by adding new DataType: EmptyArray 3. Refactor: knn expr parser. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) - [x] Refactoring
- Loading branch information
1 parent
5be183c
commit 91ec6de
Showing
19 changed files
with
1,702 additions
and
1,713 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
// Copyright(C) 2023 InfiniFlow, Inc. All rights reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
module; | ||
|
||
export module empty_array_cast; | ||
|
||
import stl; | ||
import data_type; | ||
import bound_cast_func; | ||
import column_vector_cast; | ||
import infinity_exception; | ||
import internal_types; | ||
import logical_type; | ||
import third_party; | ||
|
||
namespace infinity { | ||
|
||
struct EmptyTryCastToFixlen; | ||
|
||
export inline BoundCastFunc BindEmptyArrayCast(const DataType &source, const DataType &target) { | ||
switch (target.type()) { | ||
case LogicalType::kSparse: { | ||
return BoundCastFunc(&ColumnVectorCast::TryCastColumnVector<EmptyArrayT, SparseT, EmptyTryCastToFixlen>); | ||
} | ||
default: { | ||
UnrecoverableError("Not implemented"); | ||
} | ||
} | ||
return BoundCastFunc(nullptr); | ||
} | ||
|
||
struct EmptyTryCastToFixlen { | ||
template <typename SourceType, typename TargetType> | ||
static bool Run(SourceType, TargetType &) { | ||
UnrecoverableError(fmt::format("Not support to cast from {} to {}", DataType::TypeToString<SourceType>(), DataType::TypeToString<TargetType>())); | ||
return false; | ||
} | ||
}; | ||
|
||
template<> | ||
bool EmptyTryCastToFixlen::Run(EmptyArrayT, SparseT &target) { | ||
target.nnz_ = 0; | ||
return true; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.