-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-14230 Download server report from cluster membership list #334
Conversation
5e12ef5
to
484d710
Compare
One thing I've noticed, downloaded reports from server Whereas it's working fine with server @andyuk1986 can you check pls. |
@dpanshug what version of server do you use when running ./run-server-for-e2e.sh ? From my understanding this is ISPN 15.x feature, so you need to set 2 new variables which I have introduced in one of my last PRs for being able to run this scrip with ispn-15 server. |
I am running it on main branch i.e. |
Let me check it out |
@dpanshug @karesti seems that when we run the maven command to install the latest console changes to the server, i.e. build the console and copy the dist to the static directory of the already running server, then the generated report is corrupted. But if we will restart the server after that action, then the server is generated normally. Maybe we need to make some changes to script and maven commands so that later when tests are running we get normally generated report? |
Yes, after restarting server reports are extractable. But the other thing, after comparing reports from both server (left: Is this okay? @jabolina |
The feature is ok from the console, but we need a release of Infinispan Dev in 15 for testing |
integration testing needs to be done with a released server |
The missing files/folders can happen when some of the commands are not available in the system, or, like in this case, if it is unable to copy some of the folders from the server's root. That can happen because of file ownership, for example. +1 for Katia's suggestion of running on a released server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need a server release so will be on hold now
@dpanshug @andyuk1986 the server Dev01 has been released so we can change the version in main, 14.0 branch will remain with 14.0 server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use 15.0.0.Dev01 server here
6cfe13d
to
fe01e35
Compare
Feature is not working with the released 15.0.0.Dev01 🙄 |
I was able to use it on 15.0.0.Dev01 image. $ docker pull infinispan/server:15.0.0.Dev01
$ docker run -it -p 11222:11222 -e USER="admin" -e PASS="password" infinispan/server:15.0.0.Dev01 On the other terminal: $ curl --digest -u admin:password -O 'http://127.0.0.1:11222/rest/v2/server/report/f439e0909dbd-59934' The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well
the only issue I see is that there is no notification when the download has started.
I click the button and there is some time before the download is happening, so I don't know if it worked or not.
I would add an alert to say the download is happening (green) or that has failed for any reason with the error altert.
fe01e35
to
384bd2f
Compare
2734e9b
to
7dea22c
Compare
7dea22c
to
f96926e
Compare
* Table changed to TableComposable * Labels exported
f96926e
to
7ffbf20
Compare
https://issues.redhat.com/browse/ISPN-14230