Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14913 Create cache configuration #369

Merged
merged 2 commits into from
Jul 12, 2023
Merged

ISPN-14913 Create cache configuration #369

merged 2 commits into from
Jul 12, 2023

Conversation

dpanshug
Copy link
Collaborator

@dpanshug dpanshug changed the title Create cache configuration ISPN-14913 Create cache configuration Jun 14, 2023
@dpanshug
Copy link
Collaborator Author

This should be merged after #368

@andyuk1986
Copy link
Collaborator

andyuk1986 commented Jun 29, 2023 •
edited
Loading

I have rebased and fixed the tests. @dpanshug eventhough the tests are passing, but during tests execution exceptions are thrown in the server:
2023-06-28 14:57:02,487 ERROR [o.i.r.RestRequestHandler] ISPN012005: An error occurred while responding to the client java.util.concurrent.CompletionException: java.lang.IllegalStateException: Primitive attribute should have been detected as attribute: mode at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.lang.IllegalStateException: Primitive attribute should have been detected as attribute: mode at org.infinispan.commons.configuration.io.json.JsonConfigurationReader.nextElement(JsonConfigurationReader.java:68) at org.infinispan.configuration.parsing.ParserRegistry.parse(ParserRegistry.java:185) at org.infinispan.rest.resources.CacheResourceV2.lambda$convert$5(CacheResourceV2.java:365) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ... 4 more
or
2023-06-28 14:57:03,146 ERROR [o.i.r.RestRequestHandler] ISPN012005: An error occurred while responding to the client java.util.concurrent.CompletionException: java.lang.IllegalStateException: Primitive attribute should have been detected as attribute: media-type at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.lang.IllegalStateException: Primitive attribute should have been detected as attribute: media-type at org.infinispan.commons.configuration.io.json.JsonConfigurationReader.nextElement(JsonConfigurationReader.java:68) at org.infinispan.configuration.parsing.ParserRegistry.parse(ParserRegistry.java:185) at org.infinispan.rest.resources.CacheResourceV2.lambda$convert$5(CacheResourceV2.java:365) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ... 4 more
also
2023-06-28 14:57:03,909 ERROR [o.i.r.RestRequestHandler] ISPN012005: An error occurred while responding to the client java.util.concurrent.CompletionException: java.lang.IllegalStateException: Primitive attribute should have been detected as attribute: statistics at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.lang.IllegalStateException: Primitive attribute should have been detected as attribute: statistics at org.infinispan.commons.configuration.io.json.JsonConfigurationReader.nextElement(JsonConfigurationReader.java:68) at org.infinispan.configuration.parsing.ParserRegistry.parse(ParserRegistry.java:185) at org.infinispan.rest.resources.CacheResourceV2.lambda$convert$5(CacheResourceV2.java:365) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ... 4 more

karesti
karesti requested changes Jul 4, 2023
View reviewed changes
src/app/assets/languages/en.json Outdated Show resolved Hide resolved
@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

Screenshot 2023-07-04 at 10 11 36

@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

@dpanshug is there any change related to the fact of creating "templates" instead of caches ?

@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

Screenshot 2023-07-04 at 10 15 31

misaligned

@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

the message above, you can add the Operator as well.

@dpanshug dpanshug requested a review from domiborges July 5, 2023 11:16
@dpanshug
Copy link
Collaborator Author

dpanshug commented Jul 5, 2023 •
edited
Loading

@dpanshug is there any change related to the fact of creating "templates" instead of caches ?

@karesti By change in creating "templates" do you mean creating cache config for users without create right? The only change is I've removed the cache setup from the sidebar.

@karesti
Copy link
Collaborator

karesti commented Jul 7, 2023

@dpanshug is this preview ?

@dpanshug
Copy link
Collaborator Author

dpanshug commented Jul 7, 2023

@dpanshug is this preview ?

@andyuk1986 found some warnings during the test, waiting for a final check.

@dpanshug dpanshug removed the preview label Jul 11, 2023
@dpanshug dpanshug requested a review from karesti July 11, 2023 10:17
@andyuk1986
Copy link
Collaborator

Thank you @dpanshug, the issue with exceptions in the log is fixed.

karesti
karesti approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if Ci passes I'm ok with the PR

@karesti karesti requested review from andyuk1986 and removed request for domiborges July 12, 2023 08:52
@andyuk1986
Copy link
Collaborator

Tests started to fail, let me look into them.

@karesti
Copy link
Collaborator

karesti commented Jul 12, 2023

@andyuk1986 I changed the code so the formatting of the config does 3 calls and waits for them with a loading
do you have time to grab a look to the e2e part f it ?

@andyuk1986
Copy link
Collaborator

yes, looking into it.

@karesti
Copy link
Collaborator

karesti commented Jul 12, 2023

@andyuk1986 I accidentally pushed a wrong stuff! sorry wasting your time

@karesti karesti removed the request for review from andyuk1986 July 12, 2023 15:40
@karesti karesti merged commit c43b020 into infinispan:main Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpanshug @andyuk1986 @karesti